Interesting reading. One thing I notice - to each his own. Some like Dollar Store trinkets, some prefer homemade ones, some prefer none at all. It takes all kinds of people to make the world go 'round and all kinds of swag to make caching the experience that it is.
The male half of the hikeatrail team is not into the swag. Female half (that would be ME) enjoys it. I like leaving things I think kids would enjoy, especially. I pick up clean little toys at garage sales and bargain bins. One of my favorite things we took from a cache was a crazy little wind-up figure. I also like my giant black ant. If we find something that seems to be just trash (leaves, unadorned sticks, etc) we toss them out. Once we found a glow stick that had gotten overheated and the chemicals had reacted inside the ammo can. We cleaned out that mess, too. The worst thing we ever found - in MY opinion - was a condom.