I'm okay with most trades but I got to say that dirty old golf balls strike me as the epitome of total cheapness. Why not just pick up a nearby twig or pebble and toss that in too?
I've seen some really unbalanced trades in some of my caches as well. One cacher left a rusty old dog choker chain and took a geocoin, a travel bug and a brand new $12.00 compass.
There are some cachers out there trading really nice stuff and those that are just peddling off junk. It's purely up to the individual cacher what they trade and no one even has to make a trade but if they do, it would be nice if they made it a fair one.